feat: add --use-parameter-defaults flag #21119
Open
+562
−413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61315e5 to
3adad37
Compare
To make it easier to add new tests and parameters. Largely unchanged in functionality except: 1. All tests now perform parameter validation. 2. Add types to the parameters where before they were all defaulting to strings (except boolean, which seems to be an existing issue).
e63b201 to
31577a6
Compare
This works already in production, but not in the tests because the generated Terraform was missing quotes around the default value, which must have been breaking the parser because it was returning no parameters. Then we were removing all non-matching parameters from the request, which was all of them since the parser returned none.
This will accept parameter defaults without prompting (whether those defaults come from the template or --parameter-default). Similar to --yes, but for parameter prompts.
31577a6 to
5645473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like
--yes, but for parameter prompts. Closes #20815. Most of the diff is refactoring the tests since they were all doing the same setup and changes to markdown/golden files for the--yesdescription change, the actual code changes are fairly small 😛