test: close provisioner before creating workspace build #21219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes coder/internal#1178 I verified the fix works by adding a `time.Sleep(100 * time.Millisecond)` between the `CreateWorkspaceBuild` and `CancelWorkspaceBuild` calls. Adding this reliably triggered the flake, and when I added the fix the flake stopped happening.
df29e75 to
958fb02
Compare
mafredri
approved these changes
Dec 11, 2025
Member
mafredri
left a comment
There was a problem hiding this comment.
Is this still needed? Seems fine but a bit confusing. Ideally if we're not disabling the provisioner we'd allow the transitions to be driven by provisioner as well.
Contributor
Author
|
@mafredri Yeah it is needed. This is unrelated to the previous PR I merged. The initial transition we always want to succeed, and then the next transition we want to (maybe - depending on the test) cancel. I can't think of any other way of doing this other than stopping the provisioner. If we allow the provisioner to run we run into a race where the provisioner job is finished before we can cancel it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#1178
I verified the fix works by adding a
time.Sleep(100 * time.Millisecond)between theCreateWorkspaceBuildandCancelWorkspaceBuildcalls. Adding this reliably triggered the flake, and when I added the fix the flake stopped happening.