feat: add workspace sharing page #20931
Open
+771
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaydenh
commented
Dec 10, 2025
| {...props} | ||
| > | ||
| <span className="absolute right-2 flex items-center justify-center"> | ||
| <span className="absolute right-2 top-1/2 -translate-y-1/2 flex items-center justify-center"> |
Contributor
Author
There was a problem hiding this comment.
Vertically center the checkmark when the select takes up more vertical space
jaaydenh
commented
Dec 10, 2025
| htmlProps: HTMLAttributes<HTMLLIElement>; | ||
| } | ||
|
|
||
| export const UserOrGroupOption = ({ |
Contributor
Author
There was a problem hiding this comment.
Extracted from UserOrGroupAutocomplete
Contributor
Author
|
Not really happy with UserOrGroupAutocomplete.tsx and I would really prefer to replace it then add yet another variation but I think that is better saved for a separate PR. Also, stories for WorkspaceSharingPageView coming in a separate PR. |
aslilac
approved these changes
Dec 11, 2025
site/src/pages/WorkspaceSettingsPage/WorkspaceSharingPage/WorkspaceSharingPage.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/WorkspaceSettingsPage/WorkspaceSharingPage/WorkspaceSharingPage.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/WorkspaceSettingsPage/WorkspaceSharingPage/WorkspaceSharingPage.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/WorkspaceSettingsPage/WorkspaceSharingPage/WorkspaceSharingPage.tsx
Outdated
Show resolved
Hide resolved
| workspaceACL={workspaceACL} | ||
| isLoading={isAddingUser || isAddingGroup} | ||
| onSubmit={(value, role, resetAutocomplete) => | ||
| "members" in value |
Member
There was a problem hiding this comment.
this feels typo prone 😬 but I see that this is yet another thing taken from the old page. dang.
site/src/pages/WorkspaceSettingsPage/WorkspaceSharingPage/WorkspaceSharingPageView.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.