test(cli): fix flaky TestProvisioners_Golden (#21228)

mafredri · web-flow · commit 2e4aa729bee1 · 2025-12-11T18:19:18.000Z
Use a single base time with consistent offsets and ensure CreatedAt is set on all dbgen-created resources. Fixes coder/internal#449
diff --git a/cli/provisioners_test.go b/cli/provisioners_test.go
@@ -89,23 +89,26 @@ func TestProvisioners_Golden(t *testing.T) {
 	replace[version.ID.String()] = "00000000-0000-0000-cccc-000000000000"
 	replace[workspace.LatestBuild.ID.String()] = "00000000-0000-0000-dddd-000000000000"
 
+	now := dbtime.Now()
+
 	// Create a provisioner that's working on a job.
 	pd1 := dbgen.ProvisionerDaemon(t, coderdAPI.Database, database.ProvisionerDaemon{
 		Name:       "provisioner-1",
-		CreatedAt:  dbtime.Now().Add(1 * time.Second),
+		CreatedAt:  now.Add(time.Second),
 		LastSeenAt: sql.NullTime{Time: coderdAPI.Clock.Now().Add(time.Hour), Valid: true}, // Stale interval can't be adjusted, keep online.
 		KeyID:      codersdk.ProvisionerKeyUUIDBuiltIn,
 		Tags:       database.StringMap{"owner": "", "scope": "organization", "foo": "bar"},
 	})
 	w1 := dbgen.Workspace(t, coderdAPI.Database, database.WorkspaceTable{
 		OwnerID:    member.ID,
 		TemplateID: template.ID,
+		CreatedAt:  now.Add(time.Second),
 	})
 	wb1ID := uuid.MustParse("00000000-0000-0000-dddd-000000000001")
 	job1 := dbgen.ProvisionerJob(t, db, coderdAPI.Pubsub, database.ProvisionerJob{
 		WorkerID:  uuid.NullUUID{UUID: pd1.ID, Valid: true},
 		Input:     json.RawMessage(`{"workspace_build_id":"` + wb1ID.String() + `"}`),
-		CreatedAt: dbtime.Now().Add(2 * time.Second),
+		CreatedAt: now.Add(time.Second),
 		StartedAt: sql.NullTime{Time: coderdAPI.Clock.Now(), Valid: true},
 		Tags:      database.StringMap{"owner": "", "scope": "organization", "foo": "bar"},
 	})
@@ -114,25 +117,27 @@ func TestProvisioners_Golden(t *testing.T) {
 		JobID:             job1.ID,
 		WorkspaceID:       w1.ID,
 		TemplateVersionID: version.ID,
+		CreatedAt:         now.Add(time.Second),
 	})
 
 	// Create a provisioner that completed a job previously and is offline.
 	pd2 := dbgen.ProvisionerDaemon(t, coderdAPI.Database, database.ProvisionerDaemon{
 		Name:       "provisioner-2",
-		CreatedAt:  dbtime.Now().Add(2 * time.Second),
+		CreatedAt:  now.Add(2 * time.Second),
 		LastSeenAt: sql.NullTime{Time: coderdAPI.Clock.Now().Add(-time.Hour), Valid: true},
 		KeyID:      codersdk.ProvisionerKeyUUIDBuiltIn,
 		Tags:       database.StringMap{"owner": "", "scope": "organization"},
 	})
 	w2 := dbgen.Workspace(t, coderdAPI.Database, database.WorkspaceTable{
 		OwnerID:    member.ID,
 		TemplateID: template.ID,
+		CreatedAt:  now.Add(2 * time.Second),
 	})
 	wb2ID := uuid.MustParse("00000000-0000-0000-dddd-000000000002")
 	job2 := dbgen.ProvisionerJob(t, db, coderdAPI.Pubsub, database.ProvisionerJob{
 		WorkerID:    uuid.NullUUID{UUID: pd2.ID, Valid: true},
 		Input:       json.RawMessage(`{"workspace_build_id":"` + wb2ID.String() + `"}`),
-		CreatedAt:   dbtime.Now().Add(3 * time.Second),
+		CreatedAt:   now.Add(2 * time.Second),
 		StartedAt:   sql.NullTime{Time: coderdAPI.Clock.Now().Add(-2 * time.Hour), Valid: true},
 		CompletedAt: sql.NullTime{Time: coderdAPI.Clock.Now().Add(-time.Hour), Valid: true},
 		Tags:        database.StringMap{"owner": "", "scope": "organization"},
@@ -142,30 +147,33 @@ func TestProvisioners_Golden(t *testing.T) {
 		JobID:             job2.ID,
 		WorkspaceID:       w2.ID,
 		TemplateVersionID: version.ID,
+		CreatedAt:         now.Add(2 * time.Second),
 	})
 
 	// Create a pending job.
 	w3 := dbgen.Workspace(t, coderdAPI.Database, database.WorkspaceTable{
 		OwnerID:    member.ID,
 		TemplateID: template.ID,
+		CreatedAt:  now.Add(3 * time.Second),
 	})
 	wb3ID := uuid.MustParse("00000000-0000-0000-dddd-000000000003")
 	job3 := dbgen.ProvisionerJob(t, db, coderdAPI.Pubsub, database.ProvisionerJob{
 		Input:     json.RawMessage(`{"workspace_build_id":"` + wb3ID.String() + `"}`),
-		CreatedAt: dbtime.Now().Add(4 * time.Second),
+		CreatedAt: now.Add(3 * time.Second),
 		Tags:      database.StringMap{"owner": "", "scope": "organization"},
 	})
 	dbgen.WorkspaceBuild(t, coderdAPI.Database, database.WorkspaceBuild{
 		ID:                wb3ID,
 		JobID:             job3.ID,
 		WorkspaceID:       w3.ID,
 		TemplateVersionID: version.ID,
+		CreatedAt:         now.Add(3 * time.Second),
 	})
 
 	// Create a provisioner that is idle.
 	_ = dbgen.ProvisionerDaemon(t, coderdAPI.Database, database.ProvisionerDaemon{
 		Name:       "provisioner-3",
-		CreatedAt:  dbtime.Now().Add(3 * time.Second),
+		CreatedAt:  now.Add(4 * time.Second),
 		LastSeenAt: sql.NullTime{Time: coderdAPI.Clock.Now().Add(time.Hour), Valid: true}, // Stale interval can't be adjusted, keep online.
 		KeyID:      codersdk.ProvisionerKeyUUIDBuiltIn,
 		Tags:       database.StringMap{"owner": "", "scope": "organization"},
