Run general.yml on PRs from experimental-ci-bot #4996
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent loops, I've adjusted the ci bot workflow to only run on failures for PRs made to main (PRs made by the bot will target other branches)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the general.yml workflow to run on pull requests created by the experimental-ci-bot while preventing infinite loops by restricting the CI bot's failure diagnosis workflow to only run on PRs targeting the main branch.
Key Changes:
- Extended general.yml to run on PRs targeting branches matching
tensorzero/pr-*(bot-created PRs) - Modified the CI bot workflow condition to only trigger on failures for PRs targeting main
- Added a debug job to print the base branch reference
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/general.yml |
Extended pull_request trigger to include tensorzero/pr-* branches for bot-created PRs |
.github/workflows/tensorzero-ci-bot-failure-diagnosis.yml |
Added base branch check to prevent loops and debug job to verify branch reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent loops, I've adjusted the ci bot workflow to only run on failures for PRs made to main (PRs made by the bot will target other branches)
Important
Update CI workflows to run on additional branches and restrict failure diagnosis to main branch failures.
general.ymlto run on branchesmainandtensorzero/pr-*.tensorzero-ci-bot-failure-diagnosis.ymlto only generate patches if the base branch ismainand the workflow run failed.print-base-branchjob intensorzero-ci-bot-failure-diagnosis.ymlto log the base branch of the PR.This description was created by
for 421c0db. You can customize this summary. It will automatically update as commits are pushed.