Skip to content

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Dec 2, 2025

Important

Unify StoredDatapoint and DatapointInsert types across the codebase, updating functions and tests to use StoredDatapoint.

  • Type Unification:
    • Replace DatapointInsert with StoredDatapoint in function signatures and type definitions across multiple files, including dataset_queries.rs and mock_clickhouse_connection_info.rs.
    • Define StoredDatapoint and related types in a new file stored_datapoint.rs.
  • Function Changes:
    • Update insert_datapoints() in dataset_queries.rs and mock_clickhouse_connection_info.rs to use StoredDatapoint.
    • Modify build_analyze_input() in analyze.rs to handle StoredDatapoint.
  • Test Updates:
    • Update test cases in render_inferences.rs, analyze.rs, and analyze.rs to use StoredDatapoint.
    • Ensure all test scenarios reflect the new type usage, including error handling and input validation tests.

This description was created by Ellipsis for 05b1530. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli force-pushed the sl/unify-stored-datapoint-types branch 2 times, most recently from 4af4959 to a470450 Compare December 2, 2025 05:08
@tensorzero tensorzero deleted a comment from github-actions bot Dec 2, 2025
@shuyangli shuyangli force-pushed the sl/unify-stored-datapoint-types branch from a470450 to 0c76428 Compare December 3, 2025 18:00
@shuyangli shuyangli force-pushed the sl/unify-stored-datapoint-types branch from 0c76428 to 9c9bbc2 Compare December 8, 2025 20:11
@tensorzero tensorzero deleted a comment from github-actions bot Dec 8, 2025
@shuyangli shuyangli force-pushed the sl/unify-stored-datapoint-types branch 3 times, most recently from fec9fd7 to 2dd9dbb Compare December 10, 2025 16:13
@shuyangli shuyangli force-pushed the sl/unify-stored-datapoint-types branch from 2dd9dbb to 05b1530 Compare December 10, 2025 16:28
@shuyangli shuyangli marked this pull request as ready for review December 10, 2025 16:41
@GabrielBianconi GabrielBianconi added this pull request to the merge queue Dec 10, 2025
@Aaron1011 Aaron1011 removed this pull request from the merge queue due to a manual request Dec 10, 2025
@Aaron1011 Aaron1011 added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 42fed9d Dec 10, 2025
55 checks passed
@Aaron1011 Aaron1011 deleted the sl/unify-stored-datapoint-types branch December 10, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants