chore(dogfood): move regions to a separate module #19181
Draft
+28
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on this for now. Like I said I in Slack will be making changes to dogfood in the next few weeks, so I don't want people to start importing this new module and for it to go away or get moved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we got rid of Helsinki, it broke a bunch of templates that were hardcoding the Docker host.
I feel like this would be good to have to avoid automatic bricking if we ever change anything.
There were other ways to do this, e.g actually incorporate the parameters in the module, and the user group detection, but i didn't think that was really necessary, let me know what you think.