fix(site): add tests for createMockWebSocket
#19172
Merged
+388
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Aug 5, 2025
| publishOpen: (event: Event) => void; | ||
|
|
||
| readonly isConnectionOpen: boolean; | ||
| readonly clientSentData: readonly SocketSendData[]; |
There was a problem hiding this comment.
This was one part I was a little torn on, and I'd be open to alternative ways to track data sent from the mock socket to the mock server
It feels like the "boy scout" way of doing this would be with subscription callbacks, but since we'd likely just be checking the contents for a single isolated test case, that'd add more boilerplate to all test cases when we really just care about what data got sent
aslilac
approved these changes
Aug 6, 2025
Comment on lines
+6
to
+7
| "http://www.dog.ceo/roll-over", | ||
| "https://www.dog.ceo/roll-over", |
Comment on lines
+48
to
+49
| expect(onClose).toHaveBeenCalledTimes(1); | ||
| expect(onClose).toHaveBeenCalledWith(closeEvent); |
There was a problem hiding this comment.
this test makes me feel like I'm looking at a freshly ironed shirt. super nice!
| }); | ||
|
|
||
| it("Only registers each socket event handler once", () => { | ||
| const [socket, server] = createMockWebSocket("wss://www.dog.ceo/borf"); |
Comment on lines
+116
to
+118
| get clientSentData() { | ||
| return [...sentData]; | ||
| }, |
There was a problem hiding this comment.
cheeky little copy for immutability, nice.
jaaydenh
reviewed
Aug 7, 2025
jaaydenh
approved these changes
Aug 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #19126 and #18679
Changes made
createWebSocketto dedicated file and addressed edge cases for making it a reliable mock