-
Notifications
You must be signed in to change notification settings - Fork 956
feat: add user_secrets table #19162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: add user_secrets table #19162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcpeinhardt
reviewed
Aug 7, 2025
Emyrk
reviewed
Aug 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions before I stamp 👍
Overall LG!
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Emyrk
approved these changes
Aug 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#780
Summary of changes:
user_secrets
tableuser_secrets
table containsenv_name
andfile_path
fields which are not used at the moment, but will be used in later PRsuser_secrets
table doesn't containvalue_key_id
, I will add it in a separate migration in a dbcrypt PRResourceUserSecret
resourceResourceUserSecret
from site-wide permsResourceUserSecret
to user-wide permsResourceUserSecret
from org-wide perms; seems it's not strictly required, becauseResourceUserSecret
is not tied to organization in dbauthz wrappers?allPermsExcept
Main questions:
value_key_id
in dbcrypt PR