-
Notifications
You must be signed in to change notification settings - Fork 956
chore: upgrade to storybook 9 #18983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Chromatic is good, I'm good.
# Conflicts: # site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
npx storybook@latest upgrade
upgraded all the packages and ran some codemods. A lot of imports changed and packages were renamed as part of this upgrade.The storybook/react-router integration that we use requires migrating to react-router 7, which luckily is not a big change for us. Mostly they only publish new versions under the "react-router" package now, and not "react-router-dom". Imports for this were also updated accordingly.
There were also a couple stragglers that still used the "v2 story format", which had to be migrated to v3. Yet another codemod to run, but the changes map pretty much 1-to-1.