Skip to content

feat: add tests for dynamic parameters #18679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
+805 −12
Open

feat: add tests for dynamic parameters #18679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
71fa7f9
chore: get all initial tests passing
Parkreiner Aug 5, 2025
d6c11a9
chore: format
Parkreiner Aug 5, 2025
2b1f30a
feat: initial commit
jaaydenh Jun 30, 2025
ef46518
fix: fix more tests
jaaydenh Jun 30, 2025
e5130e9
fix: format
jaaydenh Jul 1, 2025
e4c3265
chore: more improvements
jaaydenh Jul 2, 2025
72d218a
chore: add data-testid for multiselect component
jaaydenh Jul 2, 2025
77d2cea
chore: add test for multi-select
jaaydenh Jul 2, 2025
ecd5de7
chore: test cleanup
jaaydenh Jul 3, 2025
7c250df
fix: updates for PR review
jaaydenh Jul 23, 2025
b2d155b
fix: add accessible id to Combobox
jaaydenh Jul 29, 2025
b8694f8
fix: select dropdown by button instead of combobox
jaaydenh Jul 29, 2025
1e91f6a
fix: clean up tests and use mock websocket from testhellpers
jaaydenh Aug 6, 2025
fd8c58b
fix: format
jaaydenh Aug 6, 2025
5b44667
chore: cleanup entities
jaaydenh Aug 8, 2025
4cb7a90
chore: cleanup
jaaydenh Aug 8, 2025
6a6a47d
chore: cleanup
jaaydenh Aug 8, 2025
d760feb
fix: cleanup2
jaaydenh Aug 8, 2025
0c53e9b
fix: unused exports
jaaydenh Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions site/src/components/Combobox/Combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ interface ComboboxProps {
onInputChange?: (value: string) => void;
onKeyDown?: KeyboardEventHandler<HTMLInputElement>;
onSelect: (value: string) => void;
id?: string;
}

type ComboboxOption = {
Expand All @@ -53,6 +54,7 @@ export const Combobox: FC<ComboboxProps> = ({
onInputChange,
onKeyDown,
onSelect,
id,
}) => {
const [managedOpen, setManagedOpen] = useState(false);
const [managedInputValue, setManagedInputValue] = useState("");
Expand All @@ -78,6 +80,7 @@ export const Combobox: FC<ComboboxProps> = ({
<Popover open={isOpen} onOpenChange={handleOpenChange}>
<PopoverTrigger asChild>
<Button
id={id}
variant="outline"
aria-expanded={isOpen}
className="w-full justify-between group"
Expand Down
4 changes: 4 additions & 0 deletions site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ interface MultiSelectComboboxProps {
>;
/** hide or show the button that clears all the selected options. */
hideClearAllButton?: boolean;
/** Test ID for testing purposes */
"data-testid"?: string;
}

interface MultiSelectComboboxRef {
Expand Down Expand Up @@ -205,6 +207,7 @@ export const MultiSelectCombobox = forwardRef<
commandProps,
inputProps,
hideClearAllButton = false,
"data-testid": dataTestId,
}: MultiSelectComboboxProps,
ref,
) => {
Expand Down Expand Up @@ -454,6 +457,7 @@ export const MultiSelectCombobox = forwardRef<
<Command
ref={dropdownRef}
{...commandProps}
data-testid={dataTestId}
onKeyDown={(e) => {
handleKeyDown(e);
commandProps?.onKeyDown?.(e);
Expand Down
6 changes: 5 additions & 1 deletion site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
case "dropdown": {
return (
<Combobox
id={id}
value={value ?? ""}
onSelect={(value) => onChange(value)}
options={parameter.options.map((option) => ({
Expand Down Expand Up @@ -497,7 +498,10 @@ const ParameterField: FC<ParameterFieldProps> = ({

return (
<MultiSelectCombobox
inputProps={{ id }}
inputProps={{
id: id,
}}
data-testid={`multiselect-${parameter.name}`}
options={options}
defaultOptions={selectedOptions}
onChange={(newValues) => {
Expand Down
Loading
Loading