Skip to content

feat: implement rich multi-selector #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2025
Merged

feat: implement rich multi-selector #19201

merged 6 commits into from
Aug 6, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Aug 6, 2025

Fixes: #19182

This PR implements RichMultiSelect, so that CLI users can select or input multi-select or tag-selects. Users can enter new values if form type is tag-select. See docs for dynamic parameters.

Screenshot 2025-08-06 at 15 20 33

Testing:

$ ./scripts/coder-dev.sh exp prompt-example rich-multi-select
Screenshot 2025-08-06 at 20 28 41

@mtojek mtojek requested a review from johnstcn August 6, 2025 16:44
@mtojek mtojek marked this pull request as ready for review August 6, 2025 16:44
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update cli/exp_prompts.go so we can test it out easily?

@ssncferreira
Copy link
Contributor

@mtojek the issue might be a duplicate of #19145? 🤔

@mtojek
Copy link
Member Author

mtojek commented Aug 6, 2025

@ssncferreira This might be the root cause!

@mtojek mtojek requested review from johnstcn and ssncferreira August 6, 2025 18:29
@mtojek mtojek merged commit a7fac30 into main Aug 6, 2025
33 checks passed
@mtojek mtojek deleted the 17402-fix-warn branch August 6, 2025 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: MultiSelect skips options when if default value is not set
3 participants