Skip to content

Conversation

@hieptl
Copy link
Collaborator

@hieptl hieptl commented Dec 8, 2025

Summary of PR

Description:

If v1_enable is manually set to true in the database and a user subsequently opens the UI and saves the MCP settings, the v1_enable field is automatically changed to false, even when no update to this field was intended.

Acceptance Criteria:

  • The v1_enable field must retain its existing value when saving MCP settings through the UI unless the user explicitly changes it.

Change Type

  • Bug fix
  • New feature
  • Breaking change
  • Refactor
  • Other (dependency update, docs, typo fixes, etc.)

Checklist

  • I have read and reviewed the code and I understand what the code is doing.
  • I have tested the code to the best of my ability and ensured it works as expected.

Fixes

Resolves #(issue)

Release Notes

  • Include this change in the Release Notes.

To run this PR locally, use the following command:

GUI with Docker:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.openhands.dev/openhands/runtime:2b89337-nikolaik   --name openhands-app-2b89337   docker.openhands.dev/openhands/openhands:2b89337

@hieptl hieptl self-assigned this Dec 8, 2025
@hieptl hieptl requested a review from amanape as a code owner December 8, 2025 10:52
@openhands-ai
Copy link

openhands-ai bot commented Dec 8, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Run Python Tests
    • Run Frontend Unit Tests

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #11948 at branch `hieptl/app-233`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@hieptl hieptl merged commit 959d610 into main Dec 8, 2025
25 of 27 checks passed
@hieptl hieptl deleted the hieptl/app-233 branch December 8, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants