Introduce a new algorithm "Deliver a network report". #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyasskin
reviewed
Jan 19, 2019
index.html
Outdated
| </dl> | ||
| </li> | ||
| <li> | ||
| If <var>additional body</var> is present, set each properties of |
Member
There was a problem hiding this comment.
This isn't precise enough. I think you intend to run approximately the algorithm from Object.assign, which nails down whether non-enumerable properties are included, what happens if the argument is a proxy, etc.
Using a WebIDL dictionary for additional body would be easier to specify precisely, and would satisfy @igrigorik's concern in #99 (comment).
Member
Author
There was a problem hiding this comment.
Uploaded 72f2bd6 which introduces AdditionalReportBody dictionary.
How about this?
Member
Author
|
@igrigorik, @dcreager Could you please review this PR? I have been creating a chromium CL for the distributor side reporting. |
72f2bd6 to
2f6a76d
Compare
igrigorik
reviewed
Jan 28, 2019
jyasskin
approved these changes
Jan 28, 2019
Member
jyasskin
left a comment
There was a problem hiding this comment.
A couple nits, but overall this looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to introduce an OPTIONAL
additional bodyto the algorithm of "Generate a network error report".This will be used to send the signed exchange reports #99 from the spec of "Loading Signed Exchanges" WICG/webpackage#374.
Preview | Diff