-
-
Notifications
You must be signed in to change notification settings - Fork 690
test(func-call-spacing): make tests more strict #2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -61,10 +60,9 @@ tester.run('func-call-spacing', rule, { | |||
`, | |||
errors: [ | |||
{ | |||
message: semver.lt(ESLint.version, '7.0.0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always good to see legacy code removed 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are failing, could you have a look at those please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it only fails when eslint stylistic is missing.
Any idea why this might be the case?
If not, I can revert adding the column
property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a difference in how @stylistic/func-call-spacing
and ESLint's func-call-spacing
rule report locations.
Additionally, the version of @stylistic/eslint-plugin
in the project isn’t the latest, which could be causing this issue.
Continuation of #2793
This PR converts all error assertions for
func-call-spacing
to include both error message and full location checks.