feat(ui): Restyle top navigation bar and banner #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add banner close functionality with 24-hour persistence Signed-off-by: Daniel Phillips <phiro56@gmail.com>
stockholmux
requested changes
Jul 23, 2025
| @@ -11,6 +11,9 @@ | |||
| <div class="width-limiter"> | |||
| {{ config.extra.banner | markdown | safe}} | |||
| </div> | |||
| <a href="/" class="close-banner"> | |||
| <img src="/img/icon-outline-close.svg" alt="Icon Close" width="24" height="24"/> | |||
There was a problem hiding this comment.
I don't think this image is included in the PR - when I preview the site it gives me a broken image.
| @@ -30,7 +59,10 @@ function setActiveMenuItem() { | |||
| } | |||
|
|
|||
| // Run when DOM is loaded | |||
| document.addEventListener('DOMContentLoaded', setActiveMenuItem); | |||
| document.addEventListener('DOMContentLoaded', function() { | |||
There was a problem hiding this comment.
In preview, I get a rather annoying flash and reposition on every page load because it starts on DOMContentLoaded. I know this sort of thing is limited because the site is basically flat files, but as-is it's not a good user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ui): Restyle top navigation bar and banner