feat: export CalendarRoot props #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR @RayGuo-ergou ! Can you share more details of the error you are having? It's weird that such error being thrown, as internally the component should be able to refer those types correctly. |
Contributor
Author
|
It's only happening when the build reference and expose this type for my library. // types.ts
export type MyProps = CalendarRootProps & {
...
}// index.ts
export type * from './types'or even just use in I will create a reproduction repo later. |
Contributor
Author
|
Hi @zernonia, here's a reproduction of this issue: https://github.com/RayGuo-ergou/radix-reproduction It's actually caused by th |
Contributor
Author
|
After manually export the type: |
zernonia
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Export typo
MultipleCalendarRootPropsandSingleCalendarRootPropsused byCalendarRootProps.Motivation
I was working on build an UI library based on radix-vue/shadcn-vue, this error shows up when build:
This seems a typescript limitation that interface of type alias should also be exposed.
I have also tried:
which will also work because it's an interface, but I think they are not functionally equivalent.