Skip to content

Conversation

@Tragio
Copy link
Contributor

@Tragio Tragio commented Jun 3, 2025

Hi there 👋

In continuation of #1930 I've added the maximumDays props to the DateRangePicker.

Thank you very much 🚀

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/reka-ui@1971

commit: 3395edb

@epr3
Copy link
Collaborator

epr3 commented Jun 19, 2025

Hello @Tragio 👋🏻

Thank you very much for your contribution! Could you add the property to the RangeCalendar component and inherit it in the DateRangePicker from there?

@Tragio
Copy link
Contributor Author

Tragio commented Jun 23, 2025

Hi @epr3 👋 Thank you for taking the time to review it!

Could you give me an example? I thought I was already doing that, since it was implemented in the other PR, and in this one, I'm picking the types from the RangeCalendar and using it on DateRangePickerRoot. 🤔

@epr3
Copy link
Collaborator

epr3 commented Jun 23, 2025

Hello @Tragio 👋🏻

My bad, I forgot, at the time of writing, of your previous PR and implementation. 😅

The changes are good from my side. Make sure to run pnpm docs:gen and sync the branch with v2 and I'll merge it.

Thank you for your contribution and sorry for my oversight!

@Tragio
Copy link
Contributor Author

Tragio commented Jun 23, 2025

Ehehe, no problem @epr3 💪. I've already done what you requested.

@epr3 epr3 merged commit c91f57c into unovue:v2 Jun 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants