fix(eslint-plugin): [no-floating-promises] allowForKnownSafeCalls now supports function names (fixes #11423) #11430
+85
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option Add test cases to verify that function name-based allowForKnownSafeCalls configuration works correctly for locally defined async functions.
…tion names (typescript-eslint#11423) The allowForKnownSafeCalls option was only checking type-based matching and not value-based matching, causing function name specifications like ["myAsyncFunction"] to be ignored. Now properly checks both value and type matching using valueMatchesSomeSpecifier.
- Remove skipValidation from allowForKnownSafeCalls example - Update test snapshots after fixing function name matching
|
Thanks for the PR, @976520! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit af92aea
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11430 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 503 503
Lines 51046 51056 +10
Branches 8418 8420 +2
=======================================
+ Hits 46384 46394 +10
Misses 4648 4648
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[x] Addresses an existing open issue: fixes #11423
[x] That issue was marked as accepting prs
[x] Steps in Contributing were taken
Overview
The allowForKnownSafeCalls option was only checking type-based matching using typeMatchesSomeSpecifier and completely ignoring value-based (function name) matching. This caused configurations like
["randomAsyncFunction"]to be ignored, even though the documentation indicated they should work 💖f4d5dae
8c1cc90
af92aea