[Serializer] Make data provider return type match its PHPDoc #61249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

xabbuh merged 1 commit into symfony:7.4 from MatTheCat:provider_return_type

Jul 28, 2025

+7 −9

Contributor

MatTheCat commented Jul 27, 2025

Q	A
Branch?	7.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	N/A
License	MIT

Fix CI failures like https://github.com/symfony/symfony/actions/runs/16549261399/job/46801686089?pr=60568#step:7:27

carsonbot added Status: Needs Review Bug Serializer labels

carsonbot added this to the 7.4 milestone

MatTheCat requested a review from dunglas as a code owner

July 27, 2025 08:58


          [Serializer] Make data provider return type match its PHPDoc

592254c

MatTheCat force-pushed the provider_return_type branch from 4c24045 to 592254c Compare

July 27, 2025 09:05

Member

xabbuh commented Jul 27, 2025

I wonder why this job doesn't fail on the 7.2 branch (which is the branch #60296 was merged into that introduced the patched method)

Contributor Author

MatTheCat commented Jul 27, 2025

Could it be related to #60702?

xabbuh approved these changes

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Member

xabbuh commented Jul 27, 2025

Could it be related to #60702?

You are right. That's because https://github.com/symfony/symfony/pull/60702/files#diff-cd0effce06f425599e96952f4d5f684641a683f46d9909e7c74a9f8b2f03ccd3R157 removes the Tests namespaces from the exclude-from-classmap autoload section.

Member

xabbuh commented Jul 28, 2025

Thank you @MatTheCat.

xabbuh merged commit a25fb27 into symfony:7.4

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Serializer Status: Reviewed