[VarDumper] Use unique identifier for RequestContextProvider
#61246
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Accidently clicked to fast on create PR. As it's a bug, based and targeted on |
Spomky
reviewed
Jul 29, 2025
| @@ -45,7 +45,7 @@ public function getContext(): ?array | |||
| 'uri' => $request->getUri(), | |||
| 'method' => $request->getMethod(), | |||
| 'controller' => $controller ? $this->cloner->cloneVar($controller) : $controller, | |||
| 'identifier' => spl_object_hash($request), | |||
| 'identifier' => hash('crc32b', spl_object_hash($request).$_SERVER['REQUEST_TIME_FLOAT']), | |||
There was a problem hiding this comment.
@nicolas-grekas xxh128 is already used elsewhere in Symfony for its excellent performance, low collision risk, and suitability for non-cryptographic identifiers.
Should we switch to xxh128 here and in CliContextProvider as well?
RequestContextProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates unique identifier for vardumper when running
bin/console server:dump/bin/console server:dump --format=html. The fix in theRequestContextProvidernow useshash('crc32b')in combination with$_SERVER['REQUEST_TIME_FLOAT'], which is the same as theCliContextProvider.