[Messenger] Allow SQS to handle its own retry/DLQ #60754
Merged
+93
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.4 for features". Cheers! Carsonbot |
maxbaldanza
commented
Jun 10, 2025
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
Outdated
Show resolved
Hide resolved
Thanks Carsonbot I fixed the mistake |
Allow SQS to handle retries rather then handling this by Symfony. This allows applications to use the retry strategy from SQS rather then Symfony. The default is for the message to be deleted from SQS at which point Symfony will handle the retry by deleting and then adding back in to the queue. If `delete_on_rejection` is set to `false` instead it will change the message visibility of the message on SQS and thus SQS to handle the retry mechanism
stanislav-erokhin
approved these changes
Jul 23, 2025
fabpot
approved these changes
Aug 6, 2025
|
Thank you @maxbaldanza. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on the linked issue this has a number of benefits but mainly
Allow SQS to handle retries rather then handling this by Symfony.
This allows applications to use the retry strategy from SQS rather then Symfony.
The default is for the message to be deleted from SQS at which point Symfony
will handle the retry by then adding back in to the queue.
If
delete_on_rejectionis set tofalseinstead it will change the messagevisibility of the message on SQS and thus SQS to handle the retry mechanism
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-visibility-timeout.html