Skip to content

feat(ts/fast-strip): Distinguish invalid vs unsupported #9846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdy1 merged 24 commits into from
Jan 10, 2025
+281 −268
Merged

feat(ts/fast-strip): Distinguish invalid vs unsupported #9846

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d325b17
Invalid Syntax
kdy1 Jan 6, 2025
605fe66
invalid syntax
kdy1 Jan 6, 2025
cb369c3
Update test refs
kdy1 Jan 6, 2025
f763e00
Use help
kdy1 Jan 6, 2025
79aaecb
Update test refs
kdy1 Jan 6, 2025
3b1dd2b
TsError
kdy1 Jan 8, 2025
10adcd3
Fix `@swc/minifier`
kdy1 Jan 8, 2025
7446c25
stderror for tserror
kdy1 Jan 8, 2025
c4f595f
WIP
kdy1 Jan 8, 2025
153f08e
CLone copy
kdy1 Jan 8, 2025
fe74453
Error object
kdy1 Jan 8, 2025
a3245da
code
kdy1 Jan 8, 2025
49e6b64
ErrorCode::UnsupportedSyntax
kdy1 Jan 8, 2025
f035557
Add test
kdy1 Jan 8, 2025
c9163ff
Update test refs
kdy1 Jan 8, 2025
fdea215
Merge branch 'main' into amaro-error
kdy1 Jan 8, 2025
4254a65
Add tests for error reporting
kdy1 Jan 9, 2025
d535762
fix fixture testing
kdy1 Jan 9, 2025
fbc9333
Add tests
kdy1 Jan 9, 2025
2eef3b9
Update test refs
kdy1 Jan 9, 2025
2b65aae
Update test refs
kdy1 Jan 9, 2025
c677abf
fix
kdy1 Jan 10, 2025
5fc3dc5
Merge branch 'main' into amaro-error
kdy1 Jan 10, 2025
050b9ae
Create metal-penguins-travel.md
kdy1 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
invalid syntax
  • Loading branch information
@kdy1
kdy1 committed Jan 6, 2025
commit 605fe6655e1badf7295479136f56a02239fb033d
83 changes: 52 additions & 31 deletions crates/swc_fast_ts_strip/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ pub fn operate(
err.into_diagnostic(handler).note("INVALID_SYNTAX").emit();

for e in errors {
e.into_diagnostic(handler).note("INVALID_SYNTAX").emit();
e.into_diagnostic(handler).note("Invalid syntax").emit();
}

return Err(anyhow::anyhow!("failed to parse"));
Expand All @@ -183,7 +183,7 @@ pub fn operate(

if !errors.is_empty() {
for e in errors {
e.into_diagnostic(handler).note("INVALID_SYNTAX").emit();
e.into_diagnostic(handler).note("Invalid syntax").emit();
}

return Err(anyhow::anyhow!("failed to parse"));
Expand Down Expand Up @@ -1028,10 +1028,13 @@ impl Visit for TsStrip {

fn visit_ts_export_assignment(&mut self, n: &TsExportAssignment) {
HANDLER.with(|handler| {
handler.span_err(
n.span,
"TypeScript export assignment is not supported in strip-only mode",
);
handler
.struct_span_err(
n.span,
"TypeScript export assignment is not supported in strip-only mode",
)
.note("Unsupported syntax")
.emit();
});
}

Expand All @@ -1043,10 +1046,13 @@ impl Visit for TsStrip {
}

HANDLER.with(|handler| {
handler.span_err(
n.span,
"TypeScript import equals declaration is not supported in strip-only mode",
);
handler
.struct_span_err(
n.span,
"TypeScript import equals declaration is not supported in strip-only mode",
)
.note("Unsupported syntax")
.emit();
});
}

Expand All @@ -1062,28 +1068,37 @@ impl Visit for TsStrip {

fn visit_ts_enum_decl(&mut self, e: &TsEnumDecl) {
HANDLER.with(|handler| {
handler.span_err(
e.span,
"TypeScript enum is not supported in strip-only mode",
);
handler
.struct_span_err(
e.span,
"TypeScript enum is not supported in strip-only mode",
)
.note("Unsupported syntax")
.emit();
});
}

fn visit_ts_module_decl(&mut self, n: &TsModuleDecl) {
HANDLER.with(|handler| {
handler.span_err(
n.span(),
"TypeScript namespace declaration is not supported in strip-only mode",
);
handler
.struct_span_err(
n.span(),
"TypeScript namespace declaration is not supported in strip-only mode",
)
.note("Unsupported syntax")
.emit();
});
}

fn visit_ts_namespace_decl(&mut self, n: &TsNamespaceDecl) {
HANDLER.with(|handler| {
handler.span_err(
n.span(),
"TypeScript module declaration is not supported in strip-only mode",
);
handler
.struct_span_err(
n.span(),
"TypeScript module declaration is not supported in strip-only mode",
)
.note("Unsupported syntax")
.emit();
});
}

Expand All @@ -1095,10 +1110,13 @@ impl Visit for TsStrip {

fn visit_ts_param_prop_param(&mut self, n: &TsParamPropParam) {
HANDLER.with(|handler| {
handler.span_err(
n.span(),
"TypeScript parameter property is not supported in strip-only mode",
);
handler
.struct_span_err(
n.span(),
"TypeScript parameter property is not supported in strip-only mode",
)
.note("Unsupported syntax")
.emit();
});
}

Expand Down Expand Up @@ -1133,11 +1151,14 @@ impl Visit for TsStrip {
/// See https://github.com/swc-project/swc/issues/9295
fn visit_ts_type_assertion(&mut self, n: &TsTypeAssertion) {
HANDLER.with(|handler| {
handler.span_err(
n.span,
"The angle-bracket syntax for type assertions, `<T>expr`, is not supported in \
type strip mode. Instead, use the 'as' syntax: `expr as T`.",
);
handler
.struct_span_err(
n.span,
"The angle-bracket syntax for type assertions, `<T>expr`, is not supported in \
type strip mode. Instead, use the 'as' syntax: `expr as T`.",
)
.note("Unsupported syntax")
.emit();
});

n.expr.visit_children_with(self);
Expand Down