Skip to content

Fix installation and change build default flags #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

jmigual
Copy link
Collaborator

@jmigual jmigual commented Aug 4, 2022

This PR fixes the following:

  • The installation was not working due to installing a file with the wrong name
  • The flag USE_SUBMODULES was set to OFF by default which is a different behaviour from what has been done in the past.

@jmigual jmigual merged commit dbb4547 into socketio:master Aug 4, 2022
@jmigual jmigual deleted the fix/websockets branch February 17, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant