Skip to content

MNT Remove redundant mkdir calls #31833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MNT Remove redundant mkdir calls #31833

wants to merge 1 commit into from
+3 −9

Conversation

jeremiedbb
Copy link
Member

get_data_home always create the dir

scikit-learn/sklearn/datasets/_base.py

Lines 82 to 86 in aa680bc

if data_home is None:
data_home = environ.get("SCIKIT_LEARN_DATA", join("~", "scikit_learn_data"))
data_home = expanduser(data_home)
makedirs(data_home, exist_ok=True)
return data_home

@jeremiedbb jeremiedbb added the Quick Review For PRs that are quick to review label Jul 24, 2025
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0fce640. Link to the linter CI: here

thomasjpfan
thomasjpfan approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:datasets Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiedbb @thomasjpfan