CI First step towards moving Azure CI to GHA #31832
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the first thing is that the required check for "Run unit tests" is pending because this check does not exist any more in this PR. I propose that we removed this required check for now, setting is here. Required checks are set on a job level, medium term I think we would need a job that aggregates all matrix entries results so that we can make the required checks on this single aggregating job. See https://github.com/orgs/community/discussions/4324#discussioncomment-13335158 or there is the GitHub action https://github.com/re-actors/alls-green that seems to handle this use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install.shandtest_script.shPlenty of stuff left for the future:
[float32]