DOC: Add missing link to example in plot_digits_agglomeration.py #31681
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virchan
reviewed
Jun 30, 2025
There was a problem hiding this comment.
Thanks for the PR and continuing the work from #30979, @Nachi28! I have a few comments.
- In the "Reference Issues/PRs" section of the PR description, could you please replace "
Fixes #30979" with "Towards #26927"? This helps us better track progress on the meta issue. - I also think it would be helpful to include the example link in the docstring for
FeatureAgglomeration.
Cc @StefanieSenger in advance.
I have updated both the things please verify |
virchan
reviewed
Jul 3, 2025
Comment on lines
+658
to
+663
| .. rubric:: Examples | ||
|
|
||
| * :ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This | ||
| example shows how similar features are merged together using feature | ||
| agglomeration. | ||
|
|
There was a problem hiding this comment.
The example link seems a little unnecessary here.
There was a problem hiding this comment.
I think the example link fits better under Unsupervised Dimensionality Reduction, where it's already included. Could you please remove it from here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #30979
Supersedes and continues work from PR #30979 by @AshleyNDoerfler
What does this implement/fix? Explain your changes.
This PR adds the missing reference link to the example
plot_digits_agglomeration.pyin the clustering user guide (clustering.rst), specifically under the Feature Agglomeration section.Additionally:
Any other comments?
Please let me know if there are any additional changes or improvements you'd like me to make.