MNT refactor _rescale_data in linear models into _preprocess_data #31418
+195
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Jul 24, 2025
There was a problem hiding this comment.
Thanks for the PR @lorentzenchr. I made a pass myself and I'm also confident that you didn't change existing computations. Here are some comments
| X, | ||
| y, | ||
| fit_intercept=self.fit_intercept, | ||
| copy=self.copy_X, | ||
| sample_weight=sample_weight, | ||
| rescale_with_sw=True, |
There was a problem hiding this comment.
it's the default
Suggested change
| rescale_with_sw=True, |
unless you wanted to make it extra explicit ?
There was a problem hiding this comment.
Yes, that was my intent. While reviewing code, I usually don't want to know by hard every default value of private functions.
* ValueError: non-broadcastable output operand with shape () doesn't match the broadcast shape (1,)
jeremiedbb
approved these changes
Jul 28, 2025
|
@jeremiedbb Thanks for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
Cleanup of some legacy maintenance burden which makes the code more readable - hopefully.
Any other comments?
The logic of computation should be identical - unless I made a mistake.
This should also make it easier to remove the
X_scale- again a legacy burden left as# TODO.