[MRG] BUG: enforce row-wise arg max of decision function=predicted class #15504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good to me. Is there a test associated with this already? If not, you can take the code from the issue you reference, turn it into a test, make sure it fails before this change, and make sure it passes after the change. |
|
I believe there is already a test set up here: https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/tests/test_multiclass.py#L218 |
|
Did it fail before this fix? (Ideally you want to write a test that fails before your fix, and then passes after your fix) |
0841f0e to
297d352
Compare
|
I added a small test that fails without the fix. |
…e predicted class
23733bf to
05bd8b6
Compare
|
this is still waiting for reviews, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #14124
What does this implement/fix? Explain your changes.
The estimators are traversed in reversed order to be consistent with the value returned on arg-max of decision function.
Any other comments?
The reproducer in the original issue, now runs successfully.