Fix #5135: Move well-known names to a new object WellKnownNames. #5136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes`. This breaks the circular dependency between the initialization of `object Types` and `object Names`.
This also serves as a test that there is no deadlock between `Names` and `Types` anymore. Without that fix, the addtion of `NamesTest` triggered a deadlock in virtually every run of `ir2_12/test`.
gzm0
requested changes
Mar 9, 2025
| * circular dependency between the `PrimTypeWithRef`s and their `PrimRef`s. | ||
| */ | ||
|
|
||
| def primRef: PrimRef = (charCode: @switch) match { |
There was a problem hiding this comment.
Have you considered val primRef = PrimeRef(this) and then get the refs from the types for the aliases below?
| case NullType => 'N' | ||
| case NothingType => 'E' | ||
| } | ||
| val charCode: Char = tpe.charCode |
| case DoubleType => "double" | ||
| case NullType => "null" | ||
| case NothingType => "nothing" | ||
| val displayName: String = (tpe.charCode: @switch) match { |
There was a problem hiding this comment.
Instead of the match, have you considered adding displayName as a private field to PrimTypeWithRef and just forward here?
That would essentially make PrimRef a "view" on a PrimType, which is maybe clearer overall?
e0d7551 to
53ecbe3
Compare
OK, I moved the 3rd commit to another branch https://github.com/sjrd/scala-js/tree/rearrange-init-sequence-of-primref . I'll turn it into a PR after this one is merged. It only contains the first two commits, now. |
gzm0
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And related changes.