Skip to content

feat: enable lz4 compression for warehouse #6119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 28, 2025

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jul 16, 2025

Description

  • Adds feature-flagged migrations to enable LZ4 compression for:
    • schema columns in wh_schemas, wh_staging_files, and wh_uploads (warehouse)
    • payload column in pg_notifier_queue

Linear Ticket

  • Resolves WAR-854.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.79%. Comparing base (be1fb41) to head (93a6670).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6119      +/-   ##
==========================================
+ Coverage   76.72%   76.79%   +0.07%     
==========================================
  Files         509      509              
  Lines       69578    69635      +57     
==========================================
+ Hits        53381    53475      +94     
+ Misses      13304    13262      -42     
- Partials     2893     2898       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@achettyiitr achettyiitr force-pushed the feat.segmented-storage branch from eaff64c to a497dd1 Compare July 17, 2025 11:26
@achettyiitr achettyiitr force-pushed the feat.enable-lz4-compression branch from 8794271 to 5d9396a Compare July 17, 2025 11:42
@achettyiitr achettyiitr changed the base branch from feat.segmented-storage to master July 17, 2025 11:42
@achettyiitr achettyiitr force-pushed the feat.enable-lz4-compression branch from 5d9396a to e6c988d Compare July 17, 2025 11:51
@achettyiitr achettyiitr force-pushed the feat.enable-lz4-compression branch from 3da2ba7 to 9ef9743 Compare July 28, 2025 13:18
@achettyiitr achettyiitr merged commit c8afe87 into master Jul 28, 2025
62 checks passed
@achettyiitr achettyiitr deleted the feat.enable-lz4-compression branch July 28, 2025 16:12
achettyiitr added a commit that referenced this pull request Jul 28, 2025
This was referenced Jul 29, 2025
mihir20 pushed a commit that referenced this pull request Jul 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.56.0-rc.1](v1.55.0...v1.56.0-rc.1)
(2025-07-29)


### Features

* change datatype from jsonb to text for warehouse
([#6118](#6118))
([bf90708](bf90708))
* enable lz4 compression for warehouse
([#6119](#6119))
([c8afe87](c8afe87))
* stats for notifier repo module
([#6184](#6184))
([44a0e9f](44a0e9f))
* stats for warehouse repo module
([#6179](#6179))
([07c0391](07c0391))


### Bug Fixes

* add validation to adjustedConversionTime
([#6092](#6092))
([e33bbf9](e33bbf9))
* dangling connection start time not being logged properly
([#6157](#6157))
([965e099](965e099))
* invalidate warehouse schema cache in case of export error
([#6131](#6131))
([c04a953](c04a953))
* load files not being regenerated if schema is outdated
([#6149](#6149))
([0b26aed](0b26aed))
* negative MTU count
([#6180](#6180))
([ecdd64f](ecdd64f))
* **router:** timeout doesn't reset when there are no jobs
([#6171](#6171))
([1e66738](1e66738))
* **router:** worker's batch timeout is getting resetted after new job
arrival
([#6167](#6167))
([1e66738](1e66738))
* schema not being fetched from warehouse for new warehouse destinations
([#6128](#6128))
([6e13cd4](6e13cd4))
* snowpipe events getting duplicated if status API fails
([#6125](#6125))
([2c11854](2c11854))
* update warehouse schema expiry only when fetched from warehouse
([#6130](#6130))
([e0ded8c](e0ded8c))
* **warehouse:** add mutex to mockStageFilesRepo to prevent data race in
tests (WAR-960
([#6156](#6156))
([29c6f01](29c6f01))


### Miscellaneous

* bump the go deps group across 1 directory with 12 updates
([#6178](#6178))
([f57c6e5](f57c6e5))
* clean up processor vars
([#6159](#6159))
([0dbc721](0dbc721))
* cleanup aws v1
([#6113](#6113))
([be1fb41](be1fb41))
* **jobsdb:** introduce context with timeout during add new ds loop
([#6150](#6150))
([1a151c9](1a151c9))
* **jobsdb:** remove foreign key constraint
([#6154](#6154))
([6de673f](6de673f))
* modifications and tests related chagnes for the warehouse lz4 and
jsonb to text conversion
([#6185](#6185))
([a043353](a043353))
* modifications and tests related changes for the notifier lz4 and jsonb
to text conversion
([#6183](#6183))
([918044b](918044b))
* **router:** separate worker loop batching logic from processing logic
([#6173](#6173))
([af4703d](af4703d))
* sync release v1.55.0 to main branch
([#6158](#6158))
([3d2156b](3d2156b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
itsmihir pushed a commit that referenced this pull request Jul 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.56.0-rc.2](v1.55.0...v1.56.0-rc.2)
(2025-07-29)


### Features

* change datatype from jsonb to text for warehouse
([#6118](#6118))
([bf90708](bf90708))
* enable lz4 compression for warehouse
([#6119](#6119))
([c8afe87](c8afe87))
* stats for notifier repo module
([#6184](#6184))
([44a0e9f](44a0e9f))
* stats for warehouse repo module
([#6179](#6179))
([07c0391](07c0391))


### Bug Fixes

* add validation to adjustedConversionTime
([#6092](#6092))
([e33bbf9](e33bbf9))
* dangling connection start time not being logged properly
([#6157](#6157))
([965e099](965e099))
* invalidate warehouse schema cache in case of export error
([#6131](#6131))
([c04a953](c04a953))
* load files not being regenerated if schema is outdated
([#6149](#6149))
([0b26aed](0b26aed))
* negative MTU count
([#6180](#6180))
([ecdd64f](ecdd64f))
* overwrite payloadStage in error response for aborted jobs
([#6193](#6193))
([5d82fa7](5d82fa7))
* **router:** timeout doesn't reset when there are no jobs
([#6171](#6171))
([1e66738](1e66738))
* **router:** worker's batch timeout is getting resetted after new job
arrival
([#6167](#6167))
([1e66738](1e66738))
* schema not being fetched from warehouse for new warehouse destinations
([#6128](#6128))
([6e13cd4](6e13cd4))
* snowpipe events getting duplicated if status API fails
([#6125](#6125))
([2c11854](2c11854))
* update warehouse schema expiry only when fetched from warehouse
([#6130](#6130))
([e0ded8c](e0ded8c))
* **warehouse:** add mutex to mockStageFilesRepo to prevent data race in
tests (WAR-960
([#6156](#6156))
([29c6f01](29c6f01))


### Miscellaneous

* bump the go deps group across 1 directory with 12 updates
([#6178](#6178))
([f57c6e5](f57c6e5))
* clean up processor vars
([#6159](#6159))
([0dbc721](0dbc721))
* cleanup aws v1
([#6113](#6113))
([be1fb41](be1fb41))
* **jobsdb:** introduce context with timeout during add new ds loop
([#6150](#6150))
([1a151c9](1a151c9))
* **jobsdb:** remove foreign key constraint
([#6154](#6154))
([6de673f](6de673f))
* modifications and tests related chagnes for the warehouse lz4 and
jsonb to text conversion
([#6185](#6185))
([a043353](a043353))
* modifications and tests related changes for the notifier lz4 and jsonb
to text conversion
([#6183](#6183))
([918044b](918044b))
* **router:** separate worker loop batching logic from processing logic
([#6173](#6173))
([af4703d](af4703d))
* sync release v1.55.0 to main branch
([#6158](#6158))
([3d2156b](3d2156b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
mihir20 pushed a commit that referenced this pull request Jul 30, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.56.0](v1.55.0...v1.56.0)
(2025-07-29)


### Features

* change datatype from jsonb to text for warehouse
([#6118](#6118))
([bf90708](bf90708))
* enable lz4 compression for warehouse
([#6119](#6119))
([c8afe87](c8afe87))
* stats for notifier repo module
([#6184](#6184))
([44a0e9f](44a0e9f))
* stats for warehouse repo module
([#6179](#6179))
([07c0391](07c0391))


### Bug Fixes

* add validation to adjustedConversionTime
([#6092](#6092))
([e33bbf9](e33bbf9))
* dangling connection start time not being logged properly
([#6157](#6157))
([965e099](965e099))
* invalidate warehouse schema cache in case of export error
([#6131](#6131))
([c04a953](c04a953))
* load files not being regenerated if schema is outdated
([#6149](#6149))
([0b26aed](0b26aed))
* negative MTU count
([#6180](#6180))
([ecdd64f](ecdd64f))
* overwrite payloadStage in error response for aborted jobs
([#6193](#6193))
([5d82fa7](5d82fa7))
* **router:** timeout doesn't reset when there are no jobs
([#6171](#6171))
([1e66738](1e66738))
* **router:** worker's batch timeout is getting resetted after new job
arrival
([#6167](#6167))
([1e66738](1e66738))
* schema not being fetched from warehouse for new warehouse destinations
([#6128](#6128))
([6e13cd4](6e13cd4))
* snowpipe events getting duplicated if status API fails
([#6125](#6125))
([2c11854](2c11854))
* update warehouse schema expiry only when fetched from warehouse
([#6130](#6130))
([e0ded8c](e0ded8c))
* **warehouse:** add mutex to mockStageFilesRepo to prevent data race in
tests (WAR-960
([#6156](#6156))
([29c6f01](29c6f01))


### Miscellaneous

* bump the go deps group across 1 directory with 12 updates
([#6178](#6178))
([f57c6e5](f57c6e5))
* clean up processor vars
([#6159](#6159))
([0dbc721](0dbc721))
* cleanup aws v1
([#6113](#6113))
([be1fb41](be1fb41))
* **jobsdb:** introduce context with timeout during add new ds loop
([#6150](#6150))
([1a151c9](1a151c9))
* **jobsdb:** remove foreign key constraint
([#6154](#6154))
([6de673f](6de673f))
* modifications and tests related chagnes for the warehouse lz4 and
jsonb to text conversion
([#6185](#6185))
([a043353](a043353))
* modifications and tests related changes for the notifier lz4 and jsonb
to text conversion
([#6183](#6183))
([918044b](918044b))
* **router:** separate worker loop batching logic from processing logic
([#6173](#6173))
([af4703d](af4703d))
* sync release v1.55.0 to main branch
([#6158](#6158))
([3d2156b](3d2156b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants