Add exponential backoff to bundler retries #9163
Open
+133
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edouard-chin
reviewed
Dec 5, 2025
bundler/lib/bundler/retry.rb
Outdated
Comment on lines
63
to
73
| delay = @base_delay * (2 ** (@current_run - 1)) | ||
| delay = [@max_delay, delay].min | ||
| jitter_amount = rand * @jitter | ||
| total_delay = delay + jitter_amount |
Contributor
There was a problem hiding this comment.
I think we should extract this to its own method and test this solely, without the sleep part. There are existing tests were sleep is not stubbed and they are now going to take longer to run.
Author
There was a problem hiding this comment.
Good point - made it configurable on a class level.
4f9ca1b to
8806dc1
Compare
8806dc1 to
f015c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Adding exponential backoff to bundler.
Close #5361
What is your fix for the problem, implemented in this PR?
Close #5361
Make sure the following tasks are checked