[CI] Actions - Windows mswin - use pre-built vcpkg, update to OpenSSL 3 #5792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2aeba7 to
bedc211
Compare
nobu
reviewed
Apr 15, 2022
nobu
reviewed
Apr 15, 2022
bedc211 to
13fb94c
Compare
|
The change to ext/openssl/extconf.rb may be best done in another commit or in ruby/openssl. Will change here as needed. A benefit of using vcpkg or mingw/ucrt packages is that they are often using newer versions of various dependencies than standard Ubuntu or macOS. For instance, vcpkgs libffi is 3.4.2, Ubuntu 20.04 lists 3.3, which may be patched... |
|
Added a commit, MSP-Greg/setup-msys2-gcc -> ruby/setup-msys2-gcc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds using a vcpkg 7z archive which contains all the packages needed for Ruby (libffi, libyaml, openssl, readline, & zlib).
See https://bugs.ruby-lang.org/issues/18689
Note that all unchanged workflows were disabled...See the first two commits (839626a8218a and a80d908eb6a8)
, the last commit is just for the draft PR.