ZJIT: Support invalidating constant patch points #13998
Open
+108
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
approved these changes
Jul 24, 2025
| @@ -148,6 +148,7 @@ rb_clear_constant_cache_for_id(ID id) | |||
| } | |||
|
|
|||
| rb_yjit_constant_state_changed(id); | |||
| rb_zjit_constant_state_changed(id); | |||
There was a problem hiding this comment.
If this is only keyed on one ID, does that mean we will invalidate A::B::C if D::E::C changes (because they both share C)?
There was a problem hiding this comment.
Yes when C is redefined the current implementation invalidates all jumps associated with it (confirmed with debugger and print messages). But since the callback only receives one ID, I'm not sure if there's a way to reconstruct the full constant path based on it.
It looks like YJIT behaves the same way?
@k0kubun is this correct?
|
YJIT also invalidates constants on |
k0kubun
approved these changes
Jul 24, 2025
|
lgtm after addressing ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.