forked from ThreeDotsLabs/watermill
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from ThreeDotsLabs:master #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
192
commits into
rizalgowandy:master
Choose a base branch
from
ThreeDotsLabs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the router wait for running handlers before shutdown Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com> Co-authored-by: Robert Laszczak <roblaszczak@gmail.com>
[docs] added missing docs Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com>
* improve examples validate script * fix examples validation * update examples deps * update Watermill deps * added example steps to Makefile * update leftover examples deps * Validate examples CI (#326)
…502) * use errors.Is * cleanup --------- Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com>
* refacotored sending lock of subscriber to the SendToSubscriber loop to be as close as possible to the sending part of the logic. This results in the outputbuffer acutally being utilized and fixes blocking behavior mentioned in issue 275/382 * Fix lint * Fix race --------- Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com>
* Adds feature to use ULID instead of UUID in topic name and consumer group * split ULID id generation into a seperate function * changed func name * added a field for setting function used in ID generation * Refactor a bit --------- Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com>
* Clean up resources related to the topic if there are no subscribers (#391) * fix: clean up resources in go channel pub sub * fix: removed unnecessary subscriber data removal code * fix: added timeout to test allowing cleanup to finish * fix: modified test for subscriber cleanup --------- Co-authored-by: stong <498327580@qq.com>
* Add NewMessageWithContext() This is the equivalent of calling `NewMessage()` and `SetContext()` separately, but should give a hint that when publishing messages, the message's context is used. * Docs
…umentation (#597) Signed-off-by: pxwanglu <pxwanglu@icloud.com>
Co-authored-by: Robert Laszczak <roblaszczak@gmail.com>
* migrate to backoff v5 + bump go version * slight cleanup * simplify retry middleware and fix tests --------- Co-authored-by: Evan Madurai <evan.p.madurai@pwc.com> Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com> Co-authored-by: Robert Laszczak <roblaszczak@gmail.com>
* Update TestMessageContext This test seems dedicated more to the GoChannel behavior (the ctx not being propagated), which makes no sense in the context of all Pub/Subs.
* Bump deps
* Add CommandEventMarshalerDecorator A common operation is adding some metadata to the message during marshaling. A universal decorator makes it easier than writing one from scratch.
* AddConsumerHandle The current AddNoPublisherHandler name can be confusing, especially since it's the one most often used.
* added sqlite docs PoC * cleanups * added sqlite examples and polish docs * Complete SQLite driver documention with examples (#617) * fix installation commands for SQLite drivers * fix docs sqlite example, add transaction * fix docs sqlite zombiezen and its example * expand sqlite documentation with a beta version warning and additional explanations * bump sqlite pubsub version * bump sqlite pubsub versions to 0.1.1 * fix include --------- Co-authored-by: Dmitry Kotik <7944694+dkotik@users.noreply.github.com>
Minor finishing touches to give the documentation a sense of completion. Fix one major error in transaction example: Rollback was deferred instead of Commit.
Co-authored-by: adrian.zajkowski <adrian.zajkowski@nordsec.com>
Signed-off-by: efcking <efcking@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )