Run tests on PHP 8.4 and update test environment + PCOV to avoid segfault with Xdebug 3.4.2 #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
requested changes
Jul 21, 2025
|
I refactored the CI workflow using a new approach with a ternary expression to conditionally include the appropriate ev extension version based on PHP. This greatly simplified the setup and made many of the previous redundant changes unnecessary. The tests now run cleanly in GitHub Actions with ev installed properly on all targeted PHP versions. Thanks for the feedback, happy to adjust further if needed! |
clue
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
@PaulRotmann Thanks for the update, changes look much cleaner now, all LGTM 👍
WyriHaximus
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #269, #270 and reactphp/socket#323.
Also had to remove ext-ev from default extensions, install it explicitly based on PHP version.