Add convenience properties to SharedUser and ChatShared
#4881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as in the `telegram.User` class.
…sts for it; Replace `user` and `shared_user` correspond properties implementations on a new functinos.
…rnames.py` implementation; Note: `full_name` and `effective_name` can not be easily replaced in the such way
…lved; Slots tests failed for Protocol class.
Conflicts: src/telegram/_utils/usernames.py
Closed
SharedUser and SharedUserSharedUser and ChatShared
Bibo-Joshi
reviewed
Jul 27, 2025
harshil21
reviewed
Jul 28, 2025
harshil21
approved these changes
Jul 28, 2025
Bibo-Joshi
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors
name(),fullname(),link()convenience properties of some Telegram Objects.continues work from #4713
I've skipped utilizing the new helpers in
bot.name()andbot.link()not to complicate the type vars.I could separate the refactor from the new functionality if that's preferred.