Skip to content

Update cattrs tests #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 23, 2025
Merged

Update cattrs tests #633

merged 7 commits into from
Jul 23, 2025

Conversation

Tinche
Copy link
Contributor

@Tinche Tinche commented Jul 19, 2025

Updates the CI configuration for cattrs to use uv.

@Tinche
Copy link
Contributor Author

Tinche commented Jul 19, 2025

I see actions/setup-python@v5 is being used here. In my own CI I've just switched to letting uv handle the Python installation for me.

@JelleZijlstra
Copy link
Member

Thanks! I'd be open to switching to setup-uv here.

@AlexWaygood
Copy link
Member

Yeah, I think when we first started using uv in parts of this workflow, uv wasn't yet able to install Python for you and setup-uv didn't yet exist (just the curl command). I'm also open to modernising it a bit!

@Tinche
Copy link
Contributor Author

Tinche commented Jul 20, 2025

I switched everything to astral-sh/setup-uv, let me know how it looks!

@AlexWaygood
Copy link
Member

For the ones where we're manually uv pip installing dependencies, I think you'll need to create a virtual environment to pip install them into (the --system flag for uv pip install won't work if we're using a uv-managed Python installation).

You'll also need to pin the action to an exact hash to make zizmor happy in pre-commit, I think!

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexWaygood AlexWaygood merged commit 9471a44 into python:main Jul 23, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants