-
Notifications
You must be signed in to change notification settings - Fork 262
Update conformance results for mypy 1.17.0 and pyre 0.9.25. #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I ran the conformance tests and noticed that the results have changed a bit for the latest versions of mypy and pyre.
dataclasses_kwonly.py:53: error: Too many positional arguments for "DC3" [misc] | ||
""" | ||
conformance_automated = "Fail" | ||
conformance_automated = "Pass" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual conformance scoring further up in the file should also be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
@@ -1,4 +1,4 @@ | |||
conformant = "Partial" | |||
conformant = "Pass" | |||
notes = """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "notes" section should also be removed (sorry for not mentioning that explicitly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, I should've noticed that XD
I ran the conformance tests and noticed that the results have changed a bit for the latest versions of mypy and pyre.