Add Str.kind field to typed_ast stubs #2699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently cut a new-ish release of typed-ast that [adds a new field][0] named `kind` to the `ast27.Str` and `ast3.Str` classes. This field stores whatever string modifiers (like `b` or `u`) were present on the original string. As a note, I've confirmed that this field is indeed a str (and not bytes) for ast27's Str class. [0]: python/typed_ast#49
ilevkivskyi
approved these changes
Dec 18, 2018
|
|
||
| class Str(expr): | ||
| s = ... # type: str | ||
| kind = ... # type: str |
Member
There was a problem hiding this comment.
I think we can use PEP 526 style for updated stubs (up to you).
JelleZijlstra
approved these changes
Dec 18, 2018
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Agree that PEP 526-style annotations would be preferable.
Contributor
Author
|
Sg -- I'll land this now and submit a separate PR later to switch over the annotations. |
Michael0x2a
added a commit
to Michael0x2a/mypy
that referenced
this pull request
Dec 18, 2018
Syncs typeshed, mostly to pick up python/typeshed#2699
Michael0x2a
added a commit
to python/mypy
that referenced
this pull request
Dec 18, 2018
Syncs typeshed, mostly to pick up python/typeshed#2699
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
We recently cut a new-ish release of typed-ast that [adds a new field][0] named `kind` to the `ast27.Str` and `ast3.Str` classes. This field stores whatever string modifiers (like `b` or `u`) were present on the original string. As a note, I've confirmed that this field is indeed a str (and not bytes) for ast27's Str class. [0]: python/typed_ast#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently cut a new-ish release of typed-ast that adds a new field named
kindto theast27.Strandast3.Strclasses. This field stores whatever string modifiers (likeboru) were present on the original string.As a note, I've confirmed that this field is indeed a str (and not bytes) for ast27's Str class.