gh-137238: Fix data race in _Py_slot_tp_getattr_hook
#137240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing the slot isn't thread-safe if the GIL is disabled. Don't require that the slot has been replaced when specializing.
colesbury
commented
Jul 30, 2025
| @@ -935,8 +935,7 @@ analyze_descriptor_load(PyTypeObject *type, PyObject *name, PyObject **descr, un | |||
| PyObject *getattr = _PyType_Lookup(type, &_Py_ID(__getattr__)); | |||
| has_getattr = getattr != NULL; | |||
| if (has_custom_getattribute) { | |||
| if (getattro_slot == _Py_slot_tp_getattro && | |||
| !has_getattr && | |||
| if (!has_getattr && | |||
There was a problem hiding this comment.
@Fidget-Spinner, I removed the getattro_slot == _Py_slot_tp_getattro check here because:
- It would prevent specialization of
__getattribute__Python calls in the free threaded build with this change - I don't think it's necessary. The combined
has_custom_getattributeand!has_getattrchecks are sufficient.
Does this make sense to you?
There was a problem hiding this comment.
It makes sense for the FT build. Just reasoning out loud here: From what I see above, we replace the NULL slot with the special "__getattribute__ but no __getattr__" slot at some lookup time. But it's functionally the same as just saying get_attr == NULL. So the check for the slot is redundant?
There was a problem hiding this comment.
Yeah, I should add that we already check getattro_slot == _Py_slot_tp_getattr_hook || getattro_slot == _Py_slot_tp_getattro above.
Another way of saying this:
- There's a C pseudo-specialization process of rewriting
_Py_slot_tp_getattr_hookto_Py_slot_tp_getattro - The Python specialization of rewriting
LOAD_ATTRtoLOAD_ATTR_GETATTRIBUTE_OVERRIDDENshouldn't require_Py_slot_tp_getattr_hookto have already replaced by_Py_slot_tp_getattro. It just needs to ensure the conditions are correct (i.e,__getattribute__is present,__getattr__is not and thegetattro_slotisn't overridden with something else)
Fidget-Spinner
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the slot isn't thread-safe if the GIL is disabled. Don't require that the slot has been replaced when specializing.
_Py_slot_tp_getattr_hook#137238