GH-134291: Support older macOS deployment targets for JIT builds #137211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

brandtbucher merged 2 commits into python:main from brandtbucher:macos-10-15

Jul 30, 2025

Member

brandtbucher commented Jul 29, 2025 •

edited by bedevere-app bot

Loading

This rolls back GH-126196 and adds stricter checks for newer APIs in JIT CI. We don't really need the superpowers of the newer API (rapid flip-flopping permissions on JIT pages) since our JIT doesn't use self-modifying code.

This allows downstream distributors (like uv, CC @zanieb) to ship the JIT for more users.

Issue: Check compatibility with macOS deployment target during JIT builds #134291

brandtbucher and others added 2 commits

July 29, 2025 09:10


          Support older "macOS" deployment targets

c9831e8


          blurb add

6d7efa0

brandtbucher self-assigned this

brandtbucher added interpreter-core topic-JIT labels

brandtbucher requested review from savannahostrowski and diegorusso as code owners

July 29, 2025 16:12

bedevere-app bot added the awaiting core review label

bedevere-app bot mentioned this pull request

Check compatibility with macOS deployment target during JIT builds #134291

Open

brandtbucher requested a review from zanieb

July 29, 2025 16:12

ned-deily self-requested a review

July 29, 2025 17:38

brandtbucher added the OS-mac label

Member Author

brandtbucher commented Jul 29, 2025

Performance is neutral. If you squint, startup is slightly faster and JIT-heavy benchmarks are slightly slower, but it's mostly in the noise for this machine.

diegorusso reviewed

View reviewed changes

Contributor

diegorusso left a comment

Instead of removing the support altogether, wouldn't it be nicer to call it only on supported macOS version?

Contributor

zanieb commented Jul 29, 2025

We chatted about that at PyCon but it sounded like it didn't really seem like the right trade-off because there's not a strong justification for having it in the first place.

Member Author

brandtbucher commented Jul 30, 2025

Yeah, if we left it in we'd need to test it, etc. It's intended to be a lightweight workaround for JITs with self-modifying code on newer Macs that don't support WX pages, which doesn't apply to us. I think it's cleaner to just pull it out for now.

savannahostrowski approved these changes

View reviewed changes

Member

savannahostrowski left a comment

Seems reasonable to me - I'm very +1 on wider distribution of JIT builds :)

bedevere-app bot added awaiting merge and removed awaiting core review labels

Contributor

zanieb commented Jul 30, 2025

This supersedes #134292

diegorusso approved these changes

View reviewed changes

Contributor

diegorusso left a comment

OK, if this causes issue, let's merge it. As Brandt said our JIT doesn't really modify the code while executing.

brandtbucher merged commit d591b5e into python:main

68 checks passed

bedevere-app bot removed the awaiting merge label

Member Author

brandtbucher commented Jul 30, 2025

@hugovk, @zanieb, @ned-deily: thoughts on backporting this change? I know we're in RC, but this would allow macOS distributors like uv to ship the JIT (like it does for other platforms) without carrying this patch. The new code is reverting things to the way they worked in 3.13 and part of 3.14 (and Linux) anyways, so I'm personally confident that backporting won't lead to issues.

IOSGod-ai mentioned this pull request

bpo-36144: Dictionary Union (PEP 584) #12088

Merged

Member

ned-deily commented Jul 31, 2025

thoughts on backporting this change?

I need to test the change first, which I'll do in the next day. But, assuming no problems, it should definitely be backported for 3.14. We've been handwaving about older release support while waiting for this to be fixed.

Member

hugovk commented Jul 31, 2025

Fine by me when Ned gives the nod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core OS-mac topic-JIT