Skip to content

gh-136686 Fix UnicodeEncodeError in email.generator.write when encoding multipart/related emails using utf8 policy #136848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-136686 Fix UnicodeEncodeError in email.generator.write when encoding multipart/related emails using utf8 policy #136848

wants to merge 4 commits into from
+22 −1

Conversation

EmmetAVS
Copy link

@EmmetAVS EmmetAVS commented Jul 20, 2025 •
edited
Loading

@EmmetAVS
Fixed a bug where emails with multipart/related content did not rou…
19da6df 
…nd-trip correctly through `email.parser.parsebytes()` and `as_bytes()`.
@EmmetAVS EmmetAVS requested a review from a team as a code owner July 20, 2025 06:04
@python-cla-bot
Copy link

python-cla-bot bot commented Jul 20, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jul 20, 2025
Open
@EmmetAVS
Copy link
Author

Hi, requesting a review from @StanFromIreland as on my end it looks like the review hasn't been requested properly. When you get a chance, could you take a look? Thanks.

StanFromIreland
StanFromIreland reviewed Jul 20, 2025
View reviewed changes
@StanFromIreland
Copy link
Member

Hello Emmet,
email is not really my area, the module experts have been requested.

@EmmetAVS
Copy link
Author

Hello Emmet, email is not really my area, the module experts have been requested.

Sorry about that, I saw you had reviewed another pr that made changes in Lib/email, thanks for clarifying that for me.

@EmmetAVS @StanFromIreland
Update Lib/test/test_email/test_generator.py
d29bf9a 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@etbuira
Copy link

etbuira commented Jul 27, 2025 •
edited
Loading

Hi (bug reporter here)
I doubt the fix is correct as the error is triggered whatever policy.utf8 is set to.
The example code and email can be used as test, as i have signed the CLA.

@EmmetAVS
Copy link
Author

Hi (bug reporter here) I doubt the fix is correct as the error is triggered whatever policy.utf8 is set to. The example code and email can be used as test, as i have signed the CLA.

Thanks for checking in on the pull request I made. The error doesn't trigger anymore with the changes I made, and there are no differences between the emails in semantic similarity, and since a bytes round trip doesn't necessarily guarantee exact equality/lossless conversion I felt keeping this fix would be reasonable. Your test checks in for exact equality, which is why I didn't go with that originally, if you believe otherwise or have any other feedback I would be happy to make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmmetAVS @StanFromIreland @etbuira