Skip to content

gh-137153: Add latin_N aliases to encodings.aliases #136701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-137153: Add latin_N aliases to encodings.aliases #136701

wants to merge 3 commits into from

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jul 16, 2025 •
edited
Loading

Requesting Marc since encodings.aliases has been updated, no rush, this can wait till you have time.

@StanFromIreland StanFromIreland requested a review from a team as a code owner July 16, 2025 08:48
@bedevere-app bedevere-app bot mentioned this pull request Jul 16, 2025
Open
@malemburg
Copy link
Member

I don't think this will work (and I'm surprised that the email package's test still pass):

The ALIASES dict in the email package uses hyphens for the target encoding names, whereas the encoding package's aliases use underscores.

Also note that the encoding package's aliases refer to module names used in the package and not necessarily widely accepted encoding names used in email, e.g. "iso-8859-1" is commonly used in email, but not "iso8859_1".

malemburg
malemburg requested changes Jul 27, 2025
View reviewed changes
Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments on the issue. I don't think this is a good way to "reuse" the encoding packages aliases dictionary.

@bedevere-app
Copy link

bedevere-app bot commented Jul 27, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Member Author

I withdraw my attempt on the email module, I will reuse this pr/branch to add just the aliases.

@StanFromIreland StanFromIreland changed the title gh-53144: Use encodings.aliases in email mod gh-137153: Add latin_N aliases to encodings.aliases Jul 27, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 27, 2025
Open
@StanFromIreland
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jul 27, 2025

Thanks for making the requested changes!

@malemburg: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from malemburg July 27, 2025 19:11
malemburg
malemburg approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@malemburg malemburg removed the request for review from a team July 27, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malemburg malemburg malemburg approved these changes

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @malemburg