Skip to content

gh-133125: Clarify ZipInfo.date_time attribute documentation #136082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KentaroJay
Copy link
Contributor

@KentaroJay KentaroJay commented Jun 28, 2025

@KentaroJay
Copy link
Contributor Author

This is how it looks like
image

@KentaroJay KentaroJay marked this pull request as ready for review June 28, 2025 18:44
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KentaroJay thanks for the PR! Would you be interested in adding information about the way CPython interprets the timezone of the datetime (i.e. the time is interpreted as the local timezone). This was brought up in #123059.

I can do that in a follow up if you'd prefer to keep this focused on just covering the source of the timestamp information.

tuple of six values representing the "last mod file time" and "last mod file date"
fields from the ZIP file's central directory.

.. note::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this note further down as "a tuple of six values" is lost as context when you get to "The tuple" below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note also seems very similar to the one below. I would merge the information in this note into the one below.

@KentaroJay
Copy link
Contributor Author

@emmatyping
Hello! Thanks for the comment and the review. Sure, I will work on it! Will do in like a couple of days ✅

Co-authored-by: Emma Smith <emma@emmatyping.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants