gh-133158: Adjust c-analyzer max_sizes for typeobject.c #133159
+33
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this PR should skip news. |
|
@ericsnowcurrently Please take a look. |
|
@ericsnowcurrently Please take a look as you got time. |
|
@ZeroIntensity Thanks for review! |
|
Command to run (I always forgot it): |
|
Fixed, thanks! It is ready for review. |
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
| pass | ||
| elif maxlines and self.end - self.start > maxlines: | ||
| elif self.too_much_lines(maxlines): |
There was a problem hiding this comment.
Minor, but this should be called too_many_lines, not too_much_lines.
There was a problem hiding this comment.
I did this because I want to return too_much prefix to link to previous version of code. But I think it is ok to change this prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.