Skip to content

GH-132341: Implement the identity function in the operator module #132342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-132341: Implement the identity function in the operator module #132342

wants to merge 1 commit into from

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Apr 10, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 10, 2025
Open
JelleZijlstra
JelleZijlstra reviewed May 4, 2025
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I'm not convinced we should add this feature

(trying to empty my review requests)

@skirpichev
Copy link
Contributor

Benchmark would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AA-Turner @skirpichev @JelleZijlstra