gh-126662: naming consistency for signal.ItimerError #126712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 2 commits into python:main from tungol:ItimerError

Jul 26, 2025

Contributor

tungol commented Nov 12, 2024 •

edited

Loading

This MR updates the __name__ attribute of signal.ItimerError to match its import path. Let me know if a NEWS entry is needed for this; I was on the fence about it.

Issue: Naming consistency for various types #126662


          naming consistency for signal.ItimerError

f4231f5

bedevere-app bot added the awaiting review label

bedevere-app bot mentioned this pull request

Naming consistency for various types #126662

Open

ZeroIntensity added skip news needs backport to 3.12 needs backport to 3.13 labels

ZeroIntensity approved these changes

View reviewed changes

Member

ZeroIntensity left a comment

FWIW, this is a slight breaking change, but I don't think anyone was relying on this buggy behavior anyway.

bedevere-app bot added awaiting core review and removed awaiting review labels

erlend-aasland approved these changes

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels

tomasr8 removed the needs backport to 3.12 label

serhiy-storchaka added the needs backport to 3.14 label


          Merge branch 'main' into ItimerError

5ec5bea

kumaraditya303 approved these changes

View reviewed changes

kumaraditya303 merged commit d5fa437 into python:main

39 checks passed

miss-islington-app bot commented Jul 26, 2025

Thanks @tungol for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

bedevere-app bot removed the awaiting merge label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          pythongh-126662: naming consistency for signal.ItimerError (pythonG…

a5e2fb7

…H-126712)

(cherry picked from commit d5fa437)

Co-authored-by: Stephen Morton <git@tungol.org>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          pythongh-126662: naming consistency for signal.ItimerError (pythonG…

183ee83

…H-126712)

(cherry picked from commit d5fa437)

Co-authored-by: Stephen Morton <git@tungol.org>

bedevere-app bot commented Jul 26, 2025

GH-137122 is a backport of this pull request to the 3.14 branch.

bedevere-app bot removed the needs backport to 3.14 label

bedevere-app bot commented Jul 26, 2025

GH-137123 is a backport of this pull request to the 3.13 branch.

bedevere-app bot removed the needs backport to 3.13 label

kumaraditya303 pushed a commit that referenced this pull request


          [3.13] gh-126662: naming consistency for signal.ItimerError (GH-126712

89f256e

) (#137123)

gh-126662: naming consistency for `signal.ItimerError` (GH-126712)
(cherry picked from commit d5fa437)

Co-authored-by: Stephen Morton <git@tungol.org>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels