Solved DuplexPipe test failure #860
Conversation
|
The AppVeyor doesn't like this fix, I am trying to figure out why. |
|
Hi @mgravell, My solution solves the issue, but the build machine doesn't stand the pipe tests. After spending a lot of time playing with the build, I got to the conclusion that the named pipe tests fail because the build machine doesn't have enough resources to execute the test in a timely manner so they fail on timeout. (You can see what I tested here https://github.com/amibar/protobuf-net/commits/pipes) I checked two main scearios, the original one and the Examples tests with only the message pipe tests, the paragraphs below are taken from the builds logs. As you can see when the Examples has many tests, the pipe tests takes a lot of time. DuplexPipe test log when running all Examples tests: (4916d30) The DuplexPipe test when only the pipe tests are in the Examples: (26ac5d1) Regards, |
Hi,
Looking into the code I found a possible solution to the DuplexPipe test.
In the SimpleMessagePipe test the Server calls to WaitForConnectionAsync and then calls to MessagePipe.ReceiveAsync so the server pipe is connected.
In the DuplexPipe, MessagePipe.DuplexAsync calls to MessagePipe.ReceiveAsync before the server pipe is connected, this throws exception that ruins the receiving loop.
Postponing the call to MessagePipe.DuplexAsync to after the server.WaitForConnectionAsync call, solves this issue.
Here is a PR that fixes it.
Thanks,
Ami