Skip to content

Protogen output simplified #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

las-nsc
Copy link

@las-nsc las-nsc commented Sep 21, 2021

  • Added option to use C#9 features.
  • Fully qualified namespaces now optional, can generate usings with 'usings=true' flag
  • Extensibility code now optional using 'extensible=false' flag
  • Fixed bug where enum can be 'option' or 'reserved'

@mgravell
Copy link
Member

The C#9 bits (= new()) - no problem, all good; the decision to prefer explicit naming over using was quite deliberate, though; I'd need to think on the potential impact there.

Question: what was the reason for changing the TFMs?

@las-nsc las-nsc force-pushed the las-protogen-simplified branch from 4c777d3 to 6f1e07a Compare September 22, 2021 13:07
@las-nsc
Copy link
Author

las-nsc commented Sep 22, 2021

The C#9 bits (= new()) - no problem, all good; the decision to prefer explicit naming over using was quite deliberate, though; I'd need to think on the potential impact there.

Question: what was the reason for changing the TFMs?

I've made the usings optional using a 'usings' flag

not sure what you mean by TFMs

@las-nsc
Copy link
Author

las-nsc commented Sep 22, 2021

@mgravell Any idea why the CI test is failing on the build server? It passes locally. Seems to have 49 extra errors in the EverythingProtoLangver3 test.

@las-nsc las-nsc force-pushed the las-protogen-simplified branch from a167c17 to 9ba06e3 Compare September 22, 2021 14:59
@las-nsc
Copy link
Author

las-nsc commented Sep 22, 2021

If by 'TFMs' you mean removing net462 as a target framework, I've restored it (I didn't have the targeting pack installed).

@mgravell
Copy link
Member

TFMs === target framework monikers; i.e. changing the target frameworks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants